Fix typo #3453
Merged
Fix typo #3453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @stuartleeks, that's a terrible typo 😭 Would you mind signing the CLA so we can pull it in? |
Contributor
Author
|
done :-) |
Contributor
|
Thanks! Sorry to be a pain, would you also be able to update it in https://github.com/elastic/elasticsearch-net/blob/6.x/src/Tests/Tests/ClientConcepts/LowLevel/GettingStarted.doc.cs#L67 ? The asciidoc file is generated from that source, so will only end up being overwritten on the next doc generation! |
Contributor
Author
|
I'm getting a 404 on that path... |
Contributor
|
Apologies, the test projects have moved around a bit and the docs not yet regenerated. I've updated the link in the previous comment. |
Closed
Contributor
Author
|
I'm still getting 404 for : https://github.com/elastic/elasticsearch-net/tree/6.x/src/Tests/ClientConcepts/LowLevel/GettingStarted.doc.cs |
Contributor
Contributor
Author
|
bingo - done! |
Contributor
|
Thanks @stuartleeks! |
russcam
pushed a commit
that referenced
this pull request
Oct 17, 2018
(cherry picked from commit b2bac81)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.